Hi Ming, ... > +enum i2c_baudrate { > + I2C_BR_25K = 0, > + I2C_BR_50K, > + I2C_BR_100K, > + I2C_BR_200K, > + I2C_BR_400K, > + I2C_BR_800K, > + I2C_BR_1M > +}; do we need all these frequencies? I don't see them use anywhere. Besides, can you please use a proper prefix? I2C_BR_* prefix doesn't belong to this driver. Andi