On Wed, Mar 19, 2025 at 06:41:24AM +0100, Wolfram Sang wrote: > > The datasheet I have isn't very clear on this part. Also, I'd > > like to know if there's any product line that could be negatively > > impacted by this patch. > > In my whole I2C life, I have neither seen a target supporting 10-bit > addressing nor a a system that uses 10-bit addressing. mmhhh... I have to work with my memory and dig into my documentations, but I think I've seen some STM sensors supporting also 10 bit addresses. > I am even tempted > to remove support from the kernel omce in a while. If the support is > broken in this driver, it can be removed. The documentation I have is in line with the patch (I had to read it twice, though), but I didn't want to exclude corner cases. > A working version (if > possible) can be added again by someone who needs it. I am taking bets > it will be "never". Besides, the driver never set I2C_FUNC_10BIT_ADDR, > so it really shouldn't have been used anywhere. > > Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> OK, I had a little hesitation here, but if you are sure about it (and Andy as well) I'll take it in. Thanks, Wolfram! Andi
