On 17.03.2025 10:24:11, Ming Yu wrote: [...] > > > + priv->can.clock.freq = can_clk; > > > + priv->can.bittiming_const = &nct6694_can_bittiming_nominal_const; > > > + priv->can.data_bittiming_const = &nct6694_can_bittiming_data_const; > > > + priv->can.do_set_mode = nct6694_can_set_mode; > > > + priv->can.do_get_berr_counter = nct6694_can_get_berr_counter; > > > + priv->can.ctrlmode_supported = CAN_CTRLMODE_LOOPBACK | > > > + CAN_CTRLMODE_LISTENONLY | CAN_CTRLMODE_BERR_REPORTING | > > > + CAN_CTRLMODE_FD | CAN_CTRLMODE_FD_NON_ISO; > > > > Does your device run in CAN-FD mode all the time? If so, please use > > can_set_static_ctrlmode() to set it after priv->can.ctrlmode_supported > > and remove CAN_CTRLMODE_FD from ctrlmode_supported. > > > > Our device is designed to allow users to dynamically switch between > Classical CAN and CAN-FD mode via ip link set ... fd on/off. > Therefore, CAN_CTRLMODE_FD needs to remain in ctrlmode_supported, and > can_set_static_ctrlmode() is not suitable in this case. > Please let me know if you have any concerns about this approach. Where do you evaluate if the user has configured CAN_CTRLMODE_FD or not? regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung Nürnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Attachment:
signature.asc
Description: PGP signature
