Re: [PATCH v2] i2c: ls2x: Fix frequency division register access

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 19, 2025 at 4:08 AM Binbin Zhou <zhoubinbin@xxxxxxxxxxx> wrote:
>
> According to the chip manual, the I2C register access type of
> Loongson-2K2000/LS7A is "B", so we can only access registers in byte
> form (readb/writeb).

readb()/writeb()

>
> Although Loongson-2K0500/Loongson-2K1000 do not have similar
> constraints, register accesses in byte form also behave correctly.
>
> Also, in hardware, the frequency division registers are defined as two
> separate registers (high 8-bit and low 8-bit), so we just access them
> directly as bytes.

Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>

...

> +       /*
> +        * According to the chip manual, we can only access the registers as bytes,
> +        * otherwise the high bits will be truncated.
> +        * So set the I2C frequency with a sequential writeb instead of writew.

writeb()
writew()

> +        */

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux