On Wed, Jan 01, 2025 at 04:04:22PM +0530, Atharva Tiwari wrote: > Ensure correct handling of "endianness" > for word-sized data in amd756_access > > - Convert word data into little-endian using cpu_to_le16 > - Convert word data from little-endian > to cpu native format using le16_to_cpu > > This fixes poteential issues on big-endian systems and > ensure proper byte ordering for SMBus word transacitions > > and you would be thinking why did i resend the patch > it is because kernel test robot > noticed a few warning so i fixed them first of all, thanks for your patch. I was aware that this issue had been reported by the LKP, but I initially decided to keep it as it was and queue it in i2c/i2c-host since I didn't consider it a serious issue. > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Closes: https://lore.kernel.org/oe-kbuild-all/202412311145.AKMzVNw4-lkp@xxxxxxxxx/ Now, you're treating it as a fix, which is perfectly fine. For me, it's a 50-50 case. I'll reward your second version by moving this patch to the fixes branch. However, for the next time, please: - Be transparent about your intentions: you knew I had already merged it, and you should have discussed this with me before sending a new version. - Number your patches as [PATCH v2] using 'git format-patch -v 2...'. - Avoid leaving blank spaces in the tag section: for example, there is a blank line between 'Closes:' and 'Signed-off-by:'. - Add a changelog to highlight what has changed. - Include the 'Fixes:' tag[1] (wow, this dates back to the origins of git!). - Cc the stable mailing list[2] to ensure proper visibility. In any case, don't worry—I’ll take care of this, and there's no need for you to resend it. Thanks, Andi [1] Fixes: 1da177e4c3f4 ('Linux-2.6.12-rc2') [2] Cc: <stable@xxxxxxxxxxxxxxx> # v2.6.12+
