Hi Geert, Thank you for the review. On Fri, Jan 3, 2025 at 10:48 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Prabhakar, > > Thanks for your patch! > > On Fri, Jan 3, 2025 at 10:19 AM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Refactor the IRQ handling in riic_i2c_probe by introducing a local variable > > `irq` to store IRQ numbers instead of assigning them to `ret`. This change > > improves code readability and clarity. > > > > Remove explicit error handling after `platform_get_irq()` since > > `devm_request_irq()` already handles such errors. > > Where does it handle such errors? > I only found the following check in request_threaded_irq(): > > desc = irq_to_desc(irq); > if (!desc) > return -EINVAL; > > Although irq_to_desc() takes an unsigned int, it should indeed catch > invalid (negative) interrupt numbers, but the code above would not > propagate the correct error code (e.g. -EPROBE_DEFER). > Agreed, I had missed that. I will restore the check. Cheers, Prabhakar
