On Fri, Dec 27, 2024 at 12:41 AM Andi Shyti <andi.shyti@xxxxxxxxxx> wrote:
>
> Hi Bartosz,
>
> ...
>
> > struct davinci_i2c_dev {
> > struct device *dev;
> > void __iomem *base;
> > @@ -132,13 +133,10 @@ struct davinci_i2c_dev {
> > #ifdef CONFIG_CPU_FREQ
> > struct notifier_block freq_transition;
> > #endif
> > - struct davinci_i2c_platform_data *pdata;
> > -};
> > -
> > -/* default platform data to use if not supplied in the platform_device */
> > -static struct davinci_i2c_platform_data davinci_i2c_platform_data_default = {
> > - .bus_freq = 100,
> > - .bus_delay = 0,
>
> what happened to bus_delay?
>
bus_delay is not set by means other than platform data and it defaults
to 0 so it's safe to just remove it.
> ...
>
> > + /* standard bus frequency (kHz) */
> > + unsigned int bus_freq;
> > + /* Chip has a ICPFUNC register */
> > + bool has_pfunc;
> > };
>
> > -static struct i2c_bus_recovery_info davinci_i2c_gpio_recovery_info = {
> > - .recover_bus = i2c_generic_scl_recovery,
> > - .prepare_recovery = davinci_i2c_prepare_recovery,
> > - .unprepare_recovery = davinci_i2c_unprepare_recovery,
> > -};
> > -
>
> what happened to the gpio_recovery_info?
>
Similar story: it's only ever used if there's a pdata-provided
recovery GPIO line set but nobody does it anymore.
Bartosz
