On 27/12/2024 17:57:27+0800, Ming Yu wrote: > + ret = devm_rtc_register_device(data->rtc); > + if (ret) > + return dev_err_probe(&pdev->dev, ret, "Failed to register rtc\n"); There is no error path where the error is silent in devm_rtc_register_device, the message is unnecessary . > + > + device_init_wakeup(&pdev->dev, true); > + return 0; > +} > + > +static struct platform_driver nct6694_rtc_driver = { > + .driver = { > + .name = "nct6694-rtc", > + }, > + .probe = nct6694_rtc_probe, > +}; > + > +module_platform_driver(nct6694_rtc_driver); > + > +MODULE_DESCRIPTION("USB-RTC driver for NCT6694"); > +MODULE_AUTHOR("Ming Yu <tmyu0@xxxxxxxxxxx>"); > +MODULE_LICENSE("GPL"); > +MODULE_ALIAS("platform:nct6694-rtc"); > -- > 2.34.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com