> -----Original Message-----
> From: Andi Shyti <andi.shyti@xxxxxxxxxx>
> Sent: Sunday, December 29, 2024 4:53 AM
> To: Carlos Song <carlos.song@xxxxxxx>
> Cc: Frank Li <frank.li@xxxxxxx>; Aisheng Dong <aisheng.dong@xxxxxxx>;
> shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx;
> festevam@xxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; kernel test
> robot <lkp@xxxxxxxxx>
> Subject: [EXT] Re: [PATCH] i2c: imx-lpi2c: fix build warning "function defined but
> not used"
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report this
> email' button
>
>
> Hi Carlos,
>
> On Sat, Dec 28, 2024 at 05:08:52PM +0800, Carlos Song wrote:
> > lpi2c_resume_noirq() and lpi2c_suspend_noirq() are defined but it
> > maybe unused, so should add __maybe_unused to both functions to avoid
> > build warning.
> >
> > Fixes: fa89723f7a78 ("i2c: imx-lpi2c: add target mode support")
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Closes:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore
> > .kernel.org%2Foe-kbuild-all%2F202412280835.LRAV3z0g-lkp%40intel.com%2
> F
> >
> &data=05%7C02%7Ccarlos.song%40nxp.com%7C0c5764a988ec4915626008dd
> 2781b4
> >
> 9e%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638710160215605
> 166%7CU
> >
> nknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMC
> IsIlAiO
> >
> iJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=6of
> o%2B
> > sKqDwcvVyfYcbSnnpSGUfT7abr7leD9gJ9qRy4%3D&reserved=0
> > Signed-off-by: Carlos Song <carlos.song@xxxxxxx>
>
> yeah, I have different PM configuration to catch these kind of error and I missed
> this.
>
> Rather than applying a fix over a recent patch, I am going to remove your
> original patch and ask you to send a v7 of your
> "imx-lpi2c: add target mode support".
>
I also start noticing it just after the robot's report. I don't see the warning at my previous local test so I also missed it:(.
Sorry for this. I have sent V7 with the warning fix.
> Is it OK with you?
>
> Andi
