Hi Prabhakar, On Thu, Dec 19, 2024 at 12:44:50PM +0000, Lad, Prabhakar wrote: > Hi Andi, > > On Thu, Dec 19, 2024 at 12:21 PM Andi Shyti <andi.shyti@xxxxxxxxxx> wrote: > > > > Hi Prabhakar, > > > > > diff --git a/drivers/i2c/busses/i2c-riic.c b/drivers/i2c/busses/i2c-riic.c > > > index bfaa2d728a76..01195ffd4c07 100644 > > > --- a/drivers/i2c/busses/i2c-riic.c > > > +++ b/drivers/i2c/busses/i2c-riic.c > > > @@ -320,7 +320,7 @@ static int riic_init_hw(struct riic_dev *riic) > > > : I2C_MAX_FAST_MODE_FREQ; > > > > > > if (t->bus_freq_hz > max_freq) > > > - return dev_err_probe(&riic->adapter.dev, -EINVAL, > > > + return dev_err_probe(dev, -EINVAL, > > > "unsupported bus speed %uHz (%u max)\n", > > > t->bus_freq_hz, max_freq); > > > > Which branch are you on? This change has already been introduced > > in commit 71dacb2565ed ("i2c: riic: Simplify unsupported bus > > speed handling") > > > I'm on v6.13-rc3, the above change just replaces the first parameter > in dev_err_probe(). The change introduced in commit 71dacb2565ed > ("i2c: riic: Simplify unsupported bus speed handling") does not update > the first parameter in dev_err_probe() which this patch addresses. > Actually I have fixes tag for commit 71dacb2565ed in the current > patch. oh, yes, sorry, ignore that :-) Andi