On Wed, Dec 18, 2024 at 12:42:38PM +0800, Carlos Song wrote: > Compatible string "fsl,imx7d-i2c" is not exited at i2c-imx driver > compatible string table, at the result, "fsl,imx21-i2c" will be > matched, but it will cause errata ERR007805 not be applied in fact. > > So Add "fsl,imx7d-i2c" compatible string in i2c-imx driver to apply > the errata ERR007805(https://www.nxp.com/webapp/Download?colCode= > IMX7DS_2N09P). > > "fsl,imx7d-i2c" already is documented in binding doc. This errata > fix has been included in imx6_i2c_hwdata and it is the same in all > I.MX6/7/8, so just reuse it. > > Signed-off-by: Carlos Song <carlos.song@xxxxxxx> > Signed-off-by: Haibo Chen <haibo.chen@xxxxxxx> Reviewed-by: Frank Li <Frank.Li@xxxxxxx> > --- > Change for V3: > - No ACK, so resend this patch. > Change for V2: > - I have tried to fix this issue at imx7s.dtsi in V1, according to > the community suggestion, I make V2 patch for i2c-imx driver to > avoid updating the FDT to fix an errata. Discussion in V1: > Subject: [PATCH] ARM: dts: imx7s: change i2c compatible string for applying errata ERR007805 > Message-ID: <20241021031148.2682015-1-carlos.song@xxxxxxx> (raw) > --- > drivers/i2c/busses/i2c-imx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c > index 350346a7892c..9d5caa032c5c 100644 > --- a/drivers/i2c/busses/i2c-imx.c > +++ b/drivers/i2c/busses/i2c-imx.c > @@ -335,6 +335,7 @@ static const struct of_device_id i2c_imx_dt_ids[] = { > { .compatible = "fsl,imx6sll-i2c", .data = &imx6_i2c_hwdata, }, > { .compatible = "fsl,imx6sx-i2c", .data = &imx6_i2c_hwdata, }, > { .compatible = "fsl,imx6ul-i2c", .data = &imx6_i2c_hwdata, }, > + { .compatible = "fsl,imx7d-i2c", .data = &imx6_i2c_hwdata, }, > { .compatible = "fsl,imx7s-i2c", .data = &imx6_i2c_hwdata, }, > { .compatible = "fsl,imx8mm-i2c", .data = &imx6_i2c_hwdata, }, > { .compatible = "fsl,imx8mn-i2c", .data = &imx6_i2c_hwdata, }, > -- > 2.34.1 >
