Hi Prabhakar,
On Fri, Dec 13, 2024 at 6:58 PM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Simplify the `riic_i2c_probe()` function by using the
> `devm_reset_control_get_optional_exclusive_deasserted()` API to request a
> deasserted reset line. This eliminates the need to manually deassert the
> reset control and the additional cleanup.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/i2c/busses/i2c-riic.c
> +++ b/drivers/i2c/busses/i2c-riic.c
> @@ -447,18 +442,10 @@ static int riic_i2c_probe(struct platform_device *pdev)
> return dev_err_probe(dev, PTR_ERR(riic->clk),
> "missing controller clock");
>
> - riic->rstc = devm_reset_control_get_optional_exclusive(dev, NULL);
> + riic->rstc = devm_reset_control_get_optional_exclusive_deasserted(dev, NULL);
> if (IS_ERR(riic->rstc))
> return dev_err_probe(dev, PTR_ERR(riic->rstc),
> - "Error: missing reset ctrl\n");
> -
> - ret = reset_control_deassert(riic->rstc);
> - if (ret)
> - return ret;
> -
> - ret = devm_add_action_or_reset(dev, riic_reset_control_assert, riic->rstc);
> - if (ret)
> - return ret;
> + "Failed to acquire deasserted reset control\n");
"failed", as all other error messages start with a lower-case character.
Perhaps drop the " control" from the message?
>
> for (i = 0; i < ARRAY_SIZE(riic_irqs); i++) {
> ret = platform_get_irq(pdev, riic_irqs[i].res_num);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
