On Fri, Dec 13, 2024 at 6:58 PM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Update the `riic_init_hw()` function to use the local `dev` pointer in > calls to `dev_err_probe()`. Previously, `riic_init_hw()` used > `riic->adapter.dev` in error reporting. Since this function is invoked > during the probe phase, the I2C adapter is not yet initialized, leading to > `(null) ...` being printed in error messages. This patch fixes the issue by > consistently using the local `dev` pointer, which points to > `riic->adapter.dev.parent`. > > Additionally, replace `dev_err()` with `dev_err_probe()` throughout > `riic_init_hw()` for consistency. > > Fixes: d982d66514192 ("i2c: riic: remove clock and frequency restrictions") > Fixes: 71dacb2565ed (i2c: riic: Simplify unsupported bus speed handling") > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds