> > > > @@ -944,8 +938,16 @@ static int geni_i2c_probe(struct platform_device *pdev) > > > > return 0; > > > return ret here ? yes, we need to initialize ret = 0. > > > > here? It's returning '0', as it was before. I'm failing to see > > where 'ret' is used uninitialized. What am I missing? > > > My point is - Except this place, rest of the places we are returning ret OR > standard error code. If we return as ret with initializing 0 at the start of > probe function, it would look good. As such No strict requirement. Ah, I see. Sure, I can do a "return ret" in my v2. Thanks, Andi
