On Tue, Dec 10, 2024 at 11:46 AM Ming Yu <a0282524688@xxxxxxxxx> wrote: > > This driver supports GPIO and IRQ functionality for NCT6694 MFD > device based on USB interface. > > Signed-off-by: Ming Yu <tmyu0@xxxxxxxxxxx> > --- Looks much better now. Please address one more issue I just noticed. > + > + mutex_init(&data->irq_lock); This is never destroyed. Please use devm_mutex_init() preferably to not add remove(). Also, the other mutex doesn't seem to be initialized at all. Bart
