RE: [PATCH 1/2] dt-bindings: hwmon: (pmbus/adp1050): Add bindings for adp1051, adp1055 and ltp8800

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Conor Dooley <conor@xxxxxxxxxx>
> Sent: Sunday, November 24, 2024 3:58 AM
> To: Guenter Roeck <linux@xxxxxxxxxxxx>
> Cc: Encarnacion, Cedric justine <Cedricjustine.Encarnacion@xxxxxxxxxx>;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> i2c@xxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx; linux-hwmon@xxxxxxxxxxxxxxx;
> Jean Delvare <jdelvare@xxxxxxxx>; Jonathan Corbet <corbet@xxxxxxx>;
> Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx>; Rob Herring
> <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley
> <conor+dt@xxxxxxxxxx>; Sabau, Radu bogdan <Radu.Sabau@xxxxxxxxxx>; Uwe
> Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>; Torreno, Alexis Czezar
> <AlexisCzezar.Torreno@xxxxxxxxxx>; Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Subject: Re: [PATCH 1/2] dt-bindings: hwmon: (pmbus/adp1050): Add bindings
> for adp1051, adp1055 and ltp8800
> 
> [External]
> 
> On Sat, Nov 23, 2024 at 07:56:21PM +0000, Conor Dooley wrote:
> > On Wed, Nov 20, 2024 at 10:00:19AM -0800, Guenter Roeck wrote:
> > > On 11/20/24 09:11, Conor Dooley wrote:
> > > > On Wed, Nov 20, 2024 at 11:58:25AM +0800, Cedric Encarnacion wrote:
> > > > > add dt-bindings for adp1051, adp1055, and ltp8800 pmbus.
> > > > >      ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature
> > > > >      ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature
> > > > >      LTP8800-1A/-2/-4A: 150A/135A/200A DC/DC µModule Regulator
> > > > >
> > > > > Co-developed-by: Alexis Czezar Torreno
> <alexisczezar.torreno@xxxxxxxxxx>
> > > > > Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@xxxxxxxxxx>
> > > > > Signed-off-by: Cedric Encarnacion
> <cedricjustine.encarnacion@xxxxxxxxxx>
> > > >
> > > > Why did you drop my ack?
> > > > https://lore.kernel.org/all/20241106-linoleum-kebab-
> decf14f54f76@spud/
> > > >
> > >
> > > There:
> > >
> > > > +    enum:
> > > > +      - adi,adp1050
> > > > +      - adi,adp1051
> > > > +      - adi,adp1055
> > > >
> > >
> > > Here:
> > >
> > > >> +    enum:
> > > >> +      - adi,adp1050
> > > >> +      - adi,adp1051
> > > >> +      - adi,adp1055
> > > >> +      - adi,ltp8800   <--
> > >
> > > This is a combination of two patch series. I'd personally hesitant to carry
> > > Acks along in such situations.
> >
> > Ah, I didn't notice that. Thanks for pointing it out. Cedric, in the
> > future please mention things like this if you drop an ack.
> 
> Whoops, forgot to mention that Cedric can grab the ack from the link
> above when they resubmit.

Okay. I will be carrying on acks in the future for cases like this.

Thanks,
Cedric





[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux