Re: [PATCH v3] i2c: i2c-qcom-geni: Serve transfer during early resume stage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mukesh,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20241120]
[also build test ERROR on linus/master]
[cannot apply to v6.12 v6.12-rc7 v6.12-rc6 v6.12]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mukesh-Kumar-Savaliya/i2c-i2c-qcom-geni-Serve-transfer-during-early-resume-stage/20241121-124240
base:   next-20241120
patch link:    https://lore.kernel.org/r/20241119143031.3331753-1-quic_msavaliy%40quicinc.com
patch subject: [PATCH v3] i2c: i2c-qcom-geni: Serve transfer during early resume stage
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20241122/202411221541.mTqJTK6J-lkp@xxxxxxxxx/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241122/202411221541.mTqJTK6J-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411221541.mTqJTK6J-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   In file included from drivers/i2c/busses/i2c-qcom-geni.c:6:
   In file included from include/linux/dmaengine.h:12:
   In file included from include/linux/scatterlist.h:8:
   In file included from include/linux/mm.h:2223:
   include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     518 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
>> drivers/i2c/busses/i2c-qcom-geni.c:706:28: error: no member named 'usage_count' in 'struct dev_pm_info'
     706 |                         atomic_read(&dev->power.usage_count));
         |                                      ~~~~~~~~~~ ^
   include/linux/dev_printk.h:165:39: note: expanded from macro 'dev_dbg'
     165 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                                              ^~~~~~~~~~~
   include/linux/dynamic_debug.h:274:19: note: expanded from macro 'dynamic_dev_dbg'
     274 |                            dev, fmt, ##__VA_ARGS__)
         |                                        ^~~~~~~~~~~
   include/linux/dynamic_debug.h:250:59: note: expanded from macro '_dynamic_func_call'
     250 |         _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
         |                                                                  ^~~~~~~~~~~
   include/linux/dynamic_debug.h:248:65: note: expanded from macro '_dynamic_func_call_cls'
     248 |         __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
         |                                                                        ^~~~~~~~~~~
   include/linux/dynamic_debug.h:224:15: note: expanded from macro '__dynamic_func_call_cls'
     224 |                 func(&id, ##__VA_ARGS__);                       \
         |                             ^~~~~~~~~~~
   drivers/i2c/busses/i2c-qcom-geni.c:732:28: error: no member named 'usage_count' in 'struct dev_pm_info'
     732 |                         atomic_read(&dev->power.usage_count));
         |                                      ~~~~~~~~~~ ^
   include/linux/dev_printk.h:165:39: note: expanded from macro 'dev_dbg'
     165 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                                              ^~~~~~~~~~~
   include/linux/dynamic_debug.h:274:19: note: expanded from macro 'dynamic_dev_dbg'
     274 |                            dev, fmt, ##__VA_ARGS__)
         |                                        ^~~~~~~~~~~
   include/linux/dynamic_debug.h:250:59: note: expanded from macro '_dynamic_func_call'
     250 |         _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
         |                                                                  ^~~~~~~~~~~
   include/linux/dynamic_debug.h:248:65: note: expanded from macro '_dynamic_func_call_cls'
     248 |         __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
         |                                                                        ^~~~~~~~~~~
   include/linux/dynamic_debug.h:224:15: note: expanded from macro '__dynamic_func_call_cls'
     224 |                 func(&id, ##__VA_ARGS__);                       \
         |                             ^~~~~~~~~~~
   1 warning and 2 errors generated.


vim +706 drivers/i2c/busses/i2c-qcom-geni.c

   692	
   693	static int geni_i2c_xfer(struct i2c_adapter *adap,
   694				 struct i2c_msg msgs[],
   695				 int num)
   696	{
   697		struct geni_i2c_dev *gi2c = i2c_get_adapdata(adap);
   698		struct device *dev = gi2c->se.dev;
   699		int ret;
   700	
   701		gi2c->err = 0;
   702		reinit_completion(&gi2c->done);
   703		/* Serve I2C transfer by forced resume if Runtime PM is enbled or not */
   704		if (!pm_runtime_enabled(dev) && gi2c->suspended) {
   705			dev_dbg(dev, "Runtime PM is disabled hence force resume, pm_usage_count: %d\n",
 > 706				atomic_read(&dev->power.usage_count));
   707			ret = pm_runtime_force_resume(dev);
   708			if (ret)
   709				return ret;
   710		} else {
   711			ret = pm_runtime_get_sync(gi2c->se.dev);
   712			if (ret < 0) {
   713				dev_err(gi2c->se.dev, "error turning SE resources:%d\n", ret);
   714				pm_runtime_put_noidle(gi2c->se.dev);
   715				/* Set device in suspended since resume failed */
   716				pm_runtime_set_suspended(gi2c->se.dev);
   717				return ret;
   718			}
   719		}
   720	
   721		qcom_geni_i2c_conf(gi2c);
   722	
   723		if (gi2c->gpi_mode)
   724			ret = geni_i2c_gpi_xfer(gi2c, msgs, num);
   725		else
   726			ret = geni_i2c_fifo_xfer(gi2c, msgs, num);
   727	
   728		/* if Runtime PM is disabled, do force_suspend() else autosuspend the driver */
   729		if (!pm_runtime_enabled(dev) && !gi2c->suspended) {
   730			ret = pm_runtime_force_suspend(dev);
   731			dev_dbg(dev, "Runtime PM is disabled hence force suspend, pm_usage_count: %d\n",
   732				atomic_read(&dev->power.usage_count));
   733			if (ret)
   734				return ret;
   735		} else {
   736			pm_runtime_mark_last_busy(gi2c->se.dev);
   737			pm_runtime_put_autosuspend(gi2c->se.dev);
   738		}
   739	
   740		gi2c->cur = NULL;
   741		gi2c->err = 0;
   742		return ret;
   743	}
   744	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux