On 20/11/2024 18:11, Conor Dooley wrote: > On Wed, Nov 20, 2024 at 11:58:25AM +0800, Cedric Encarnacion wrote: >> add dt-bindings for adp1051, adp1055, and ltp8800 pmbus. >> ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature >> ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature >> LTP8800-1A/-2/-4A: 150A/135A/200A DC/DC µModule Regulator >> >> Co-developed-by: Alexis Czezar Torreno <alexisczezar.torreno@xxxxxxxxxx> >> Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@xxxxxxxxxx> >> Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@xxxxxxxxxx> > > Why did you drop my ack? > https://lore.kernel.org/all/20241106-linoleum-kebab-decf14f54f76@spud/ So that's a v2? Or v3? Then should be marked correctly. Please start using b4. I already asked analog.com for this in few cases. Feel free not to use b4 if you send correct patches, but this is not the case here. A nit, subject: drop second/last, redundant "bindings for". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 Best regards, Krzysztof
