Hi Tyrone, Sorry for the late reply! ... > > > @@ -2172,7 +2191,6 @@ static int npcm_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, > > > } > > > > > > npcm_i2c_init_params(bus); > > > - bus->dest_addr = slave_addr; > > > > We can now get rid of slave_addr. It's just used in > > npcm_i2c_master_start_xmit(). Right? > > Yes, slave_addr is just used as the link > https://github.com/torvalds/linux/blob/master/drivers/i2c/busses/i2c-npcm7xx.c#L2182 > suggests with this patch. What I mean is that slave_addr now is completely unused. We declare it, we initialize it to msg0->addr and it stays like this. What I'm suggesting is to remove it completely. Andi
