Re: [PATCH 1/2] dt-bindings: at24: add ST M24256E Additional Write lockable page support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bartosz,

On Mon, Oct 21, 2024 at 8:36 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> On Mon, Oct 21, 2024 at 8:14 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> > On Sun, Oct 20, 2024 at 06:29:13AM +0200, Marek Vasut wrote:
> > > On 10/18/24 3:27 PM, Rob Herring wrote:
> > > > On Thu, Oct 17, 2024 at 08:41:25PM +0200, Marek Vasut wrote:
> > > > > The ST M24256E behaves as a regular M24C256, except for the E variant
> > > > > which uses up another I2C address for Additional Write lockable page.
> > > > > This page is 64 Bytes long and can contain additional data. Add entry
> > > > > for it, so users can describe that page in DT. Note that users still
> > > > > have to describe the main M24C256 area separately as that is on separate
> > > > > I2C address from this page.
> > > >
> > > > I think this should be modelled as 1 node having 2 addresses, not 2
> > > > nodes.
> > > We had the exact same discussion regarding M24C32D, see:
> > >
> > > https://lore.kernel.org/all/CAMRc=MdTu1gagX-L4_cHmN9aUCoKhN-b5i7yEeszKSdr+BuROg@xxxxxxxxxxxxxx/
> >
> > Seems like kernel implementation details dictating the binding to me.
>
> Yeah, that's on me. I would have known better today but 8 years ago
> the DT situation was much more volatile.

And there's no way we can fix that for new devices?  Perhaps even
for old devices, by counting the number of entries in the "reg"
compatible value?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds





[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux