On 2024/11/5 22:21, Andi Shyti wrote: > Hy Troy, > > On Mon, Nov 04, 2024 at 08:23:23PM +0800, Troy Mitchell wrote: >> On 2024/10/31 19:43, Andi Shyti wrote: >>> Hi Tony, > > Sorry, I misread your name :-/ It doesn't matter > >>> On Mon, Oct 28, 2024 at 01:32:18PM +0800, Troy Mitchell wrote: >>>> Hi all, >>>> >>>> This patch implements I2C driver for the SpacemiT K1 SoC, >>>> providing basic support for I2C read/write communication which >>>> compatible with standard I2C bus specifications. >>>> >>>> In this version, the driver defaults to use fast-speed-mode and >>>> interrupts for transmission, and does not support DMA, high-speed mode, or FIFO. >>>> >>>> The docs of I2C can be found here, in chapter 16.1 I2C [1] >>>> >>>> Link: https://developer.spacemit.com/documentation?token=Rn9Kw3iFHirAMgkIpTAcV2Arnkf#part5 [1] >>>> >>>> Troy Mitchell (2): >>>> dt-bindings: i2c: spacemit: add support for K1 SoC >>>> i2c: spacemit: add support for SpacemiT K1 SoC >>> >>> As Krzysztof has asked, please do provide the changelog, it's >>> important to track the progress of your series. >> I saw a compilation warning sent to me by the robot, and I've >> fixed the warning. Should I resend V2 with the changelog >> what I miss or send V3? > > Please send a v3. When there are compilation issues, normally > patches are less keen to be reviewed. > > You can add the changelog in the Patch 0/2 to avoid editing all > the .patch files. Thanks! I'll send v3 after I get a response from Samuel. > > Thanks, > Andi -- Troy Mitchell
