On 10/31/24 13:13, Vladimir Zapolskiy wrote:
Hi Andi,
On 10/31/24 12:44, Andi Shyti wrote:
Hi Jiapeng,
On Tue, Oct 29, 2024 at 10:09:31AM +0800, Jiapeng Chong wrote:
Variable ret is not effectively used, so delete it.
drivers/i2c/busses/i2c-qcom-cci.c:526:16: warning: variable ‘cci_clk_rate’ set but not used.
Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11532
Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
thanks for your patch! Applied to i2c/i2c-host
Thanks,
Andi
FWIW I've noticed that my Reviewed-by tag was added to the accepted change,
while it was the conditional one... Actually I don't know how to be aware
of such nuances, if only b4 tool is used, likely there is no way for it.
Hopefully I'm not too picky with it.
If it still matters, this one apparently unnoticed candidate would
have been a better choice:
https://lore.kernel.org/linux-i2c/20241031095339.76535-1-jiapeng.chong@xxxxxxxxxxxxxxxxx
--
Best wishes,
Vladimir
