> -----Original Message----- > From: Andi Shyti <andi.shyti@xxxxxxxxxx> > Sent: Thursday, October 24, 2024 9:23 PM > To: Tommy Huang <tommy_huang@xxxxxxxxxxxxxx> > Cc: Andrew Jeffery <andrew@xxxxxxxxxxxxxxxxxxxx>; > brendanhiggins@xxxxxxxxxx; benh@xxxxxxxxxxxxxxxxxxx; joel@xxxxxxxxx; > BMC-SW <BMC-SW@xxxxxxxxxxxxxx>; linux-aspeed@xxxxxxxxxxxxxxxx; > openbmc@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > stable@xxxxxxxxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH] i2c: aspeed: Consider i2c reset for muti-master case > > Hi Tommy, > > On Tue, Oct 22, 2024 at 02:42:08AM +0000, Tommy Huang wrote: > > Hi Andrew, > > > > Thanks for your comments. > > I want to fix the situation when our controller is set as target mode and > reading / writing by other i2c host. > > However, this host is stopped by any other reason (DC on/off..etc). > > It will cause the controller is stuck in this situation. > > But I find it might not have clear hints to identify this situation is normal > or abnormal. > > So, this patch should not be applied into mainstream. > > Please, avoid top posting, I don't understand which part of the original > message you are trying to comment on. Got it. > Second thing, please, before sending a patch, always always always make sure > that checkpatch.pl reports '0' errors and '0' > warnings, except for few sporadic cases. Sure. Thanks for your suggestion. > > Andi
