Re: [PATCH] i2c: Switch back to struct platform_driver::remove()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Sep 29, 2024 at 09:21:57AM +0200, Uwe Kleine-König wrote:
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers.
> 
> Convert all platform drivers below drivers/i2c to use .remove(), with
> the eventual goal to drop struct platform_driver::remove_new(). As
> .remove() and .remove_new() have the same prototypes, conversion is done
> by just changing the structure member name in the driver initializer.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx>
> ---
> Hello,
> 
> given the simplicity of the individual changes I do this all in a single
> patch. Please tell and I will happily split it.

I think one patch is perfect.

> I based this on Fridays's next, feel free to drop changes that result in
> a conflict when you come around to apply this. I'll care for the fallout
> at a later time then. (Having said that, if you use b4 am -3 and git am
> -3, there should be hardly any conflict.)

On rc1 and Andi's current i2c-host-next, this works without conflicts.

> Note I didn't Cc: all the individual driver maintainers to not trigger
> sending limits and spam filters.

Perfect again IMO.

Andi, do you want to take it? This is a typical after-rc1-cleanup patch,
so it should be applied soon for testing and send to Linus for rc2.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux