Re: [PATCH] i2c: qcom-geni: Keep comment why interrupts start disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram,

...

> > That said, I agree that a comment should be added back. The original
> > comment no longer fits as well as it did before. A more
> > appropriate comment would be:
> > 
> > /*
> >  * Do not enable interrupts by default to allow the system to enter
> >  * low-power mode. The driver will explicitly enable interrupts when
> >  * needed using enable_irq().
> >  */
> > 
> > Does it make sense?
> 
> Frankly, I think this is too detailed, we can't have kernel driver 101
> in each and every driver. But I will happily stand back if you insist
> because we are entering a bike-shedding area. My proposal would be:
> 
>  /* Keep interrupts disabled initially to allow for low-power modes */

Ack!

> Chose what you prefer!
> 
> Happy hacking,

Thanks,
Andi

>    Wolfram




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux