On Thu, Sep 12, 2024 at 07:24:48PM +0100, Arturs Artamonovs wrote: > Bindigs for ADI ADSP-SC5xx reset controller Typo. Here and the subject. Please write complete sentences. > > Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@xxxxxxxxxx> > Co-developed-by: Utsav Agarwal <Utsav.Agarwal@xxxxxxxxxx> > Signed-off-by: Utsav Agarwal <Utsav.Agarwal@xxxxxxxxxx> > Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@xxxxxxxxxxx> > Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@xxxxxxxxxxx> > Co-developed-by: Greg Malysa <greg.malysa@xxxxxxxxxxx> > Signed-off-by: Greg Malysa <greg.malysa@xxxxxxxxxxx> > --- > .../bindings/soc/adi/adi,reset-controller.yaml | 38 ++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/adi/adi,reset-controller.yaml b/Documentation/devicetree/bindings/soc/adi/adi,reset-controller.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..7a6df1cfb709d818d5e3dbcd202938d6aaaaaa9b > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/adi/adi,reset-controller.yaml > @@ -0,0 +1,38 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/adi/adi,reset-controller.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices Reset Controller for SC5XX processor family > + > +maintainers: > + - Arturs Artamonovs <arturs.artamonovs@xxxxxxxxxx> > + - Utsav Agarwal <Utsav.Agarwal@xxxxxxxxxx> > + > +description: | Don't need '|' > + SHARC and ARM core reset control unit for starting/stopping/resetting > + processors Complete sentences for top-level description. > + > +properties: > + compatible: > + enum: > + - adi,reset-controller Too generic. > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + rcu: rcu@3108c000 { > + compatible = "adi,reset-controller"; > + reg = <0x3108c000 0x1000>; > + status = "okay"; Don't need status in examples. Shouldn't a reset controller use the reset binding (i.e. #reset-cells)? All you patches seem to have similar issues, so I'm not going to comment on all of them. Please read the documentation in Documentation/devicetree/bindings/. It doesn't seem like you have. Rob
