Re: [PATCH v3 2/2] pca954x: Reset if channel select fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v3 2/2] pca954x: Reset if channel select fails
From: "Wojciech Siudy (Nokia)" <wojciech.siudy@xxxxxxxxx>
Date: Fri, 13 Sep 2024 10:23:17 +0000
Accept-language: pl-PL, en-US
Cc: "linux-i2c@xxxxxxxxxxxxxxx" <linux-i2c@xxxxxxxxxxxxxxx>, "devicetree@xxxxxxxxxxxxxxx" <devicetree@xxxxxxxxxxxxxxx>, Peter Rosin <peda@xxxxxxxxxx>, Andi Shyti <andi.shyti@xxxxxxxxxx>
In-reply-to: <20240913095730.GD21327@pendragon.ideasonboard.com>
Msip_labels:
References: <DB6PR07MB35097CC094E6995B2F66A17A9D652@DB6PR07MB3509.eurprd07.prod.outlook.com> <20240913095730.GD21327@pendragon.ideasonboard.com>
Thread-index: AQHbBakvQJCOfWHDv0+K266wlnTGW7JVe14AgAAGjpU=
Thread-topic: [PATCH v3 2/2] pca954x: Reset if channel select fails

Hi!

> timeout_reset is set but never used. Am I missing something?
Unfortunately you are right, it should be in this line as additional condition:
if (ret == -ETIMEDOUT && (data->reset_cont || data->reset_gpio))

Please look forward for another patch.

Regards,
Wojciech

References:
- [PATCH v3 2/2] pca954x: Reset if channel select fails
  - From: Wojciech Siudy (Nokia)
- Re: [PATCH v3 2/2] pca954x: Reset if channel select fails
  - From: Laurent Pinchart

Prev by Date: [PATCH v3 6/6] i2c: npcm: Enable slave in eob interrupt
Next by Date: Re: [PATCH v7 06/10] i2c: Introduce OF component probe function
Previous by thread: Re: [PATCH v3 2/2] pca954x: Reset if channel select fails
Next by thread: [GIT PULL] i2c-host-fixes for v6.11-rc8
Index(es):
- Date
- Thread

[Index of Archives] [Linux GPIO] [Linux SPI] [Linux Hardward Monitoring] [LM Sensors] [Linux USB Devel] [Linux Media] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]

Powered by Linux