On Thu, Sep 12, 2024, at 18:24, Arturs Artamonovs via B4 Relay wrote: > From: Arturs Artamonovs <arturs.artamonovs@xxxxxxxxxx> > > Add adi clock driver header file Are you sure this is necessary? If the clk controller follows a logical structure, it's usually easier to identify individual clks by the way the hardware is laid out. > +#ifndef DT_BINDINGS_CLOCK_ADI_SC5XX_CLOCK_H > +#define DT_BINDINGS_CLOCK_ADI_SC5XX_CLOCK_H > + > +#define ADSP_SC598_CLK_DUMMY 0 > +#define ADSP_SC598_CLK_SYS_CLKIN0 1 > +#define ADSP_SC598_CLK_SYS_CLKIN1 2 > +#define ADSP_SC598_CLK_CGU0_PLL_IN 3 > +#define ADSP_SC598_CLK_CGU0_VCO_OUT 4 Unlike the DT compatible strings, these #defines don't have to be specific to a particular SoC, you could just reuse them for a family of chips even if they each use a slightly different subset. Maybe name them "ADSP_CLK_*" or "ADSP_SC5XX_CLK_*"? > +#define ADSP_SC598_CLK_END 80 This should not be part of the binding, in particular you probably want to be able to extend this in order to support additional chips. Arnd