Hi Andi
On 9/12/2024 11:45, Andi Shyti wrote:
> Hi Shyam,
>
> what does it mean signature? Do you mean "parameter list"?
Yes. I mean "parameter list". I can amend it in the next version.
Thanks,
Shyam
>
> Andi
>
> On Wed, Sep 11, 2024 at 05:24:00PM GMT, Shyam Sundar S K wrote:
>> Currently, `piix4_transaction()` accepts only one parameter, which is the
>> `i2c_adapter` information. This approach works well as long as SB800 SMBus
>> port accesses are confined to the piix4 driver. However, with the
>> implementation of a separate ASF driver and the varying address spaces
>> across drivers, it is necessary to change the function signature of
>> `piix4_transaction()` to include the port address. This modification
>> allows other drivers that use piix4 to pass the specific port details they
>> need to operate on.
>>
>> Co-developed-by: Sanket Goswami <Sanket.Goswami@xxxxxxx>
>> Signed-off-by: Sanket Goswami <Sanket.Goswami@xxxxxxx>
>> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx>
>> ---
>> drivers/i2c/busses/i2c-piix4.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
>> index 4e32d57ae0bf..69b362db6d0c 100644
>> --- a/drivers/i2c/busses/i2c-piix4.c
>> +++ b/drivers/i2c/busses/i2c-piix4.c
>> @@ -536,10 +536,8 @@ static int piix4_setup_aux(struct pci_dev *PIIX4_dev,
>> return piix4_smba;
>> }
>>
>> -static int piix4_transaction(struct i2c_adapter *piix4_adapter)
>> +static int piix4_transaction(struct i2c_adapter *piix4_adapter, unsigned short piix4_smba)
>> {
>> - struct i2c_piix4_adapdata *adapdata = i2c_get_adapdata(piix4_adapter);
>> - unsigned short piix4_smba = adapdata->smba;
>> int temp;
>> int result = 0;
>> int timeout = 0;
>> @@ -675,7 +673,7 @@ static s32 piix4_access(struct i2c_adapter * adap, u16 addr,
>>
>> outb_p((size & 0x1C) + (ENABLE_INT9 & 1), SMBHSTCNT);
>>
>> - status = piix4_transaction(adap);
>> + status = piix4_transaction(adap, piix4_smba);
>> if (status)
>> return status;
>>
>> --
>> 2.25.1
>>
