On Mon, Sep 09, 2024 at 09:23:11AM GMT, Li Zetao wrote: > Currently, the nzxt-kraken2 module needs to maintain hid resources > by itself. Use devm_hid_hw_start_and_open helper to ensure that hid > resources are consistent with the device life cycle, and release > hid resources before device is released. At the same time, it can avoid > the goto-release encoding, drop the fail_and_close and fail_and_stop > lables, and directly return the error code when an error occurs. > > Further optimization, use devm_hwmon_device_register_with_info to replace > hwmon_device_register_with_info, the remote operation can be completely > deleted, and the kraken2_priv_data no longer needs to hold hwmon device. > > Signed-off-by: Li Zetao <lizetao1@xxxxxxxxxx> Acked-by: Jonas Malaco <jonas@xxxxxxxxxxxx>