On 2024-09-09 03:23:12 GMT+02:00, Li Zetao wrote: > Currently, the nzxt-kraken2 module needs to maintain hid resources > by itself. Use devm_hid_hw_start_and_open helper to ensure that hid > resources are consistent with the device life cycle, and release > hid resources before device is released. At the same time, it can avoid > the goto-release encoding, drop the fail_and_close and fail_and_stop > lables, and directly return the error code when an error occurs. > > Signed-off-by: Li Zetao <lizetao1@xxxxxxxxxx> > --- The commit message references the nzxt-kraken2 module, instead of nzxt-kraken3 which it touches. Other than that, Reviewed-by: Aleksa Savic <savicaleksa83@xxxxxxxxx>