Hi, On Fri, Aug 30, 2024 at 11:46:39AM GMT, Tyrone Ting wrote: > Modify i2c frequency from table parameters > for NPCM i2c modules. > > Supported frequencies are: > > 1. 100KHz > 2. 400KHz > 3. 1MHz I agree with Andy, please add a good explanation for this change. > Signed-off-by: Tyrone Ting <kfting@xxxxxxxxxxx> > --- > drivers/i2c/busses/i2c-npcm7xx.c | 230 +++++++++++++++++++------------ > 1 file changed, 144 insertions(+), 86 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c > index 67d156ed29b9..cac4ea0b69b8 100644 > --- a/drivers/i2c/busses/i2c-npcm7xx.c > +++ b/drivers/i2c/busses/i2c-npcm7xx.c > @@ -263,6 +263,121 @@ static const int npcm_i2caddr[I2C_NUM_OWN_ADDR] = { > #define I2C_FREQ_MIN_HZ 10000 > #define I2C_FREQ_MAX_HZ I2C_MAX_FAST_MODE_PLUS_FREQ > > +struct SMB_TIMING_T { Please run checkpatch.pl before sending the patches. Thanks, Andi