Hi Shyam,
...
> +enum piix4_algo {
> + SMBUS_SB800,
> + SMBUS_LEGACY,
please don't use the SMBUS_ prefix, this driver has its own
prefix which is PIIX4. I suggest calling these enums PIIX4_SMBUS
and PIIX4_SB800.
> +};
> +
> struct i2c_piix4_adapdata {
> unsigned short smba;
>
> @@ -173,6 +178,7 @@ struct i2c_piix4_adapdata {
> bool notify_imc;
> u8 port; /* Port number, shifted */
> struct sb800_mmio_cfg mmio_cfg;
> + u8 algo_select;
> };
>
> static int piix4_sb800_region_request(struct device *dev,
> @@ -929,7 +935,7 @@ static struct i2c_adapter *piix4_aux_adapter;
> static int piix4_adapter_count;
>
> static int piix4_add_adapter(struct pci_dev *dev, unsigned short smba,
> - bool sb800_main, u8 port, bool notify_imc,
> + u8 piix4_algo, u8 port, bool notify_imc,
^^
why "u8" and not "enum piix4_algo"?
Thanks,
Andi
