Hi Andy: Thank you for your feedback. Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> 於 2024年9月2日 週一 下午7:54寫道： > > On Mon, Sep 02, 2024 at 09:40:09AM +0800, Tyrone Ting wrote: > > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> 於 2024年8月31日 週六 上午3:16寫道： > > > On Fri, Aug 30, 2024 at 11:46:38AM +0800, Tyrone Ting wrote: > > > > Store the client address earlier since it's used in the i2c_recover_bus > > > > logic flow. > > > > > > Here no explanation why it's now left-shifted by one bit. > > > > The address is stored from bit 1 to bit 7 in the register for sending > > the i2c address later. > > Yes, but previously it was stored w/o that shift. > Previously, the address was stored w/o that shift and with that shift in the following call to npcm_i2c_master_start_xmit, just like what https://github.com/torvalds/linux/blob/master/drivers/i2c/busses/i2c-npcm7xx.c#L2043 shows. Since there are cases that the i2c_recover_bus gets called at the early stage of the function npcm_i2c_master_xfer, the address is stored with the shift and used in the i2c_recover_bus call. > > I'll write some comments about the left-shifted by one bit behavior > > above this modification in next patch set. > > -- > With Best Regards, > Andy Shevchenko > > Thank you. Regards, Tyrone
