On Mon, Aug 26, 2024 at 05:08:42PM +0200, Wolfram Sang wrote: > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > --- > > Question: Should I remove 'smbus_alert' from the enum of > 'interrupt-names'? It is already documented here: > > https://github.com/devicetree-org/dt-schema/commit/c51125d571cac9596048e888a856d70650e400e0 No, because dtschema is not specific there and allows any combination, while device bindings should make it constrained. > > > .../bindings/i2c/renesas,rcar-i2c.yaml | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml b/Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml > index 6cc60c3f61cd..2eed3ae7c57d 100644 > --- a/Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml > @@ -60,7 +60,20 @@ properties: > maxItems: 1 > > interrupts: > - maxItems: 1 > + minItems: 1 > + maxItems: 2 > + description: > + Without interrupt-names, the first interrupt listed must be the one > + of the IP core, the second optional interrupt listed must handle > + SMBALERT#, likely a GPIO. With interrupt-names the same... unless you want to allow anything? No clue what is being fixed here, no commit msg. Which interrupts are flexible? Why main can be skipped suddenly (or was it always)? > + > + interrupt-names: > + minItems: 1 > + maxItems: 2 > + items: > + enum: > + - main > + - smbus_alert Best regards, Krzysztof
