Re: [PATCH 1/3] i2c: Replace list-based mechanism for handling auto-detected clients

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Heiner,

kernel test robot noticed the following build errors:

[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on linus/master v6.11-rc4 next-20240822]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Heiner-Kallweit/i2c-Replace-list-based-mechanism-for-handling-auto-detected-clients/20240822-044950
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
patch link:    https://lore.kernel.org/r/9eb8879b-f975-41fc-a098-0ad189cc583d%40gmail.com
patch subject: [PATCH 1/3] i2c: Replace list-based mechanism for handling auto-detected clients
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20240822/202408222315.iGb5Ttng-lkp@xxxxxxxxx/config)
compiler: powerpc64-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240822/202408222315.iGb5Ttng-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408222315.iGb5Ttng-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   sound/ppc/keywest.c: In function 'keywest_attach_adapter':
>> sound/ppc/keywest.c:69:70: error: 'struct i2c_driver' has no member named 'clients'
      69 |                       &to_i2c_driver(keywest_ctx->client->dev.driver)->clients);
         |                                                                      ^~


vim +69 sound/ppc/keywest.c

5de4155bb3760f Jean Delvare       2009-04-20  28  
5de4155bb3760f Jean Delvare       2009-04-20  29  /*
5de4155bb3760f Jean Delvare       2009-04-20  30   * This is kind of a hack, best would be to turn powermac to fixed i2c
5de4155bb3760f Jean Delvare       2009-04-20  31   * bus numbers and declare the sound device as part of platform
5de4155bb3760f Jean Delvare       2009-04-20  32   * initialization
5de4155bb3760f Jean Delvare       2009-04-20  33   */
^1da177e4c3f41 Linus Torvalds     2005-04-16  34  static int keywest_attach_adapter(struct i2c_adapter *adapter)
^1da177e4c3f41 Linus Torvalds     2005-04-16  35  {
5de4155bb3760f Jean Delvare       2009-04-20  36  	struct i2c_board_info info;
04a9af2e038423 Wolfram Sang       2020-03-26  37  	struct i2c_client *client;
^1da177e4c3f41 Linus Torvalds     2005-04-16  38  
^1da177e4c3f41 Linus Torvalds     2005-04-16  39  	if (! keywest_ctx)
^1da177e4c3f41 Linus Torvalds     2005-04-16  40  		return -EINVAL;
^1da177e4c3f41 Linus Torvalds     2005-04-16  41  
903dba1eae4927 Jean Delvare       2009-05-14  42  	if (strncmp(adapter->name, "mac-io", 6))
ac397c80de8950 Wolfram Sang       2015-05-09  43  		return -EINVAL; /* ignored */
^1da177e4c3f41 Linus Torvalds     2005-04-16  44  
5de4155bb3760f Jean Delvare       2009-04-20  45  	memset(&info, 0, sizeof(struct i2c_board_info));
75b1a8f9d62e50 Joe Perches        2021-01-04  46  	strscpy(info.type, "keywest", I2C_NAME_SIZE);
5de4155bb3760f Jean Delvare       2009-04-20  47  	info.addr = keywest_ctx->addr;
04a9af2e038423 Wolfram Sang       2020-03-26  48  	client = i2c_new_client_device(adapter, &info);
04a9af2e038423 Wolfram Sang       2020-03-26  49  	if (IS_ERR(client))
04a9af2e038423 Wolfram Sang       2020-03-26  50  		return PTR_ERR(client);
04a9af2e038423 Wolfram Sang       2020-03-26  51  	keywest_ctx->client = client;
04a9af2e038423 Wolfram Sang       2020-03-26  52  
18c4078489fe06 Takashi Iwai       2009-10-01  53  	/*
18c4078489fe06 Takashi Iwai       2009-10-01  54  	 * We know the driver is already loaded, so the device should be
18c4078489fe06 Takashi Iwai       2009-10-01  55  	 * already bound. If not it means binding failed, and then there
18c4078489fe06 Takashi Iwai       2009-10-01  56  	 * is no point in keeping the device instantiated.
18c4078489fe06 Takashi Iwai       2009-10-01  57  	 */
a7cde6d25c494e Lars-Peter Clausen 2013-09-29  58  	if (!keywest_ctx->client->dev.driver) {
18c4078489fe06 Takashi Iwai       2009-10-01  59  		i2c_unregister_device(keywest_ctx->client);
18c4078489fe06 Takashi Iwai       2009-10-01  60  		keywest_ctx->client = NULL;
18c4078489fe06 Takashi Iwai       2009-10-01  61  		return -ENODEV;
18c4078489fe06 Takashi Iwai       2009-10-01  62  	}
^1da177e4c3f41 Linus Torvalds     2005-04-16  63  	
5de4155bb3760f Jean Delvare       2009-04-20  64  	/*
5de4155bb3760f Jean Delvare       2009-04-20  65  	 * Let i2c-core delete that device on driver removal.
5de4155bb3760f Jean Delvare       2009-04-20  66  	 * This is safe because i2c-core holds the core_lock mutex for us.
5de4155bb3760f Jean Delvare       2009-04-20  67  	 */
5de4155bb3760f Jean Delvare       2009-04-20  68  	list_add_tail(&keywest_ctx->client->detected,
a7cde6d25c494e Lars-Peter Clausen 2013-09-29 @69  		      &to_i2c_driver(keywest_ctx->client->dev.driver)->clients);
^1da177e4c3f41 Linus Torvalds     2005-04-16  70  	return 0;
^1da177e4c3f41 Linus Torvalds     2005-04-16  71  }
^1da177e4c3f41 Linus Torvalds     2005-04-16  72  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux