Re: [PATCH v3 4/5] arm64: dts: qcom: sdm670: add camcc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/20/24 01:10, Richard Acayan wrote:
The camera clock controller on SDM670 controls the clocks that drive the
camera subsystem. The clocks are the same as on SDM845. Add the camera
clock controller for SDM670.

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
Signed-off-by: Richard Acayan <mailingradian@xxxxxxxxx>
---
  arch/arm64/boot/dts/qcom/sdm670.dtsi | 10 ++++++++++
  1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm670.dtsi b/arch/arm64/boot/dts/qcom/sdm670.dtsi
index 187c6698835d..ba93cef33dbb 100644
--- a/arch/arm64/boot/dts/qcom/sdm670.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm670.dtsi
@@ -1400,6 +1400,16 @@ spmi_bus: spmi@c440000 {
  			#interrupt-cells = <4>;
  		};
+ camcc: clock-controller@ad00000 {
+			compatible = "qcom,sdm845-camcc";

Here it's wrong, and the compatible property value shall contain
"qcom,sdm670-camcc", probably it could contain both values though.

It may require to add a new compatible to dt documentation and,
if needed, to the corresponding clock driver.

+			reg = <0 0x0ad00000 0 0x10000>;
+			clocks = <&rpmhcc RPMH_CXO_CLK>;
+			clock-names = "bi_tcxo";
+			#clock-cells = <1>;
+			#reset-cells = <1>;
+			#power-domain-cells = <1>;
+		};
+
  		mdss: display-subsystem@ae00000 {
  			compatible = "qcom,sdm670-mdss";
  			reg = <0 0x0ae00000 0 0x1000>;

--
Best wishes,
Vladimir




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux