On 14/08/2024 00:00, Richard Acayan wrote:
Add the camera subsystem and CCI used to interface with cameras on the Snapdragon 670. Signed-off-by: Richard Acayan <mailingradian@xxxxxxxxx> ---
+ clocks = <&camcc CAM_CC_CAMNOC_AXI_CLK>, + <&camcc CAM_CC_SOC_AHB_CLK>, + <&camcc CAM_CC_SLOW_AHB_CLK_SRC>, + <&camcc CAM_CC_CPAS_AHB_CLK>, + <&camcc CAM_CC_CCI_CLK>, + <&camcc CAM_CC_CCI_CLK_SRC>; + clock-names = "camnoc_axi", + "soc_ahb", + "slow_ahb_src", + "cpas_ahb", + "cci", + "cci_src";
These "_src" clocks should be dropped, per similar comment on &camss{}; in the previous.
+ + assigned-clocks = <&camcc CAM_CC_CAMNOC_AXI_CLK>, + <&camcc CAM_CC_CCI_CLK>; + assigned-clock-rates = <80000000>, <37500000>;
Do you need to assign the CAMNOC_AXI_CLK here ? More usual to specify it in drivers/media/platform/qcom/camss/camss.c for your SoC
grep camnoc_axi drivers/media/platform/qcom/camss/* | wc -l 26 Other than that looks fine. Will wait your v3 before R/B. --- bod
