Hi, Wolfram, On 08.08.2024 18:08, Wolfram Sang wrote: > On Thu, Jul 11, 2024 at 02:52:00PM +0300, Claudiu wrote: >> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> >> >> Enable runtime PM autosuspend support for the RIIC driver. With this, in >> case there are consecutive xfer requests the device wouldn't be runtime >> enabled/disabled after each consecutive xfer but after the >> the delay configured by user. With this, we can avoid touching hardware >> registers involved in runtime PM suspend/resume saving in this way some >> cycles. The default chosen autosuspend delay is zero to keep the >> previous driver behavior. >> >> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> > > Basically, OK with me. I'd just like a comment here like: > > /* Default 0 to save power. Can be overridden via sysfs for lower latency */ Ok, I'll update it in the next version. Thank you, Claudiu Beznea >> + pm_runtime_set_autosuspend_delay(dev, 0); >> + pm_runtime_use_autosuspend(dev); > > Other than that: > > Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> >
