Hi Mary, just skimmed through fast... > + dev_dbg(&adapter->dev, > + "%s: rd: %p/%ld wr: %p/%ld flags: 0x%08lx %s\n", > + __func__, rdbuf, rdlen, raw_wrbuf, wrlen + 1, > + flags, > + msgs[i].flags & I2C_M_RD ? "READ" : "WRITE"); please mind the alignment: align everuthyng under the "(". ... > + ret = i2c_add_adapter(&priv->adapter); > + if (ret < 0) { > + dev_err(&pdev->dev, "registration failed\n"); > + return ret; please use dev_err_probe(); Andi