Re: [PATCH v3 2/2] i2c: piix4: Register SPDs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 16, 2024 at 07:50:04PM GMT, Thomas Weißschuh wrote:
> On 2024-07-16 19:46:43+0000, Andi Shyti wrote:
> > On Fri, Jul 12, 2024 at 02:53:49PM GMT, Wolfram Sang wrote:
> > > > Only the first 8 slots are supported. If the system has more,
> > > > then these will not be visible.
> > > > 
> > > > The AUX bus can not be probed as on some platforms it reports all
> > > > devices present and all reads return "0".
> > > > This would allow the ee1004 to be probed incorrectly.
> > > 
> > > I think this information would also be helpful as a comment above the
> > > code. But to allow this series to be applied now, I think an incremental
> > > patch will do. With Heiner's ack, I think this can go in now.
> > 
> > I agree with Wolfram here. Are you up for a v4 or do you want me
> > to add the comment while pushing?
> 
> I also agree. My first interpretation of that message was that I would
> send the incremental patch during the 6.12 cycle.
> But if it's still fine for 6.11, even better.
> If you could add the comment, that would be great,
> but I'm also fine with resending.

That's why I'm pushing... Wolfram is allowing me a pull request
part 2 and I wanted this to go in.

I will fix the comment then.

Thanks,
Andi




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux