Hi Wolfram,
On Sat, Jul 06, 2024 at 01:20:26PM GMT, Wolfram Sang wrote:
> Change the wording of this driver wrt. the newest I2C v7 and SMBus 3.2
> specifications and replace "master/slave" with more appropriate terms.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/i2c/busses/i2c-ljca.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-ljca.c b/drivers/i2c/busses/i2c-ljca.c
> index b4927622177c..0b70621cf9d3 100644
> --- a/drivers/i2c/busses/i2c-ljca.c
> +++ b/drivers/i2c/busses/i2c-ljca.c
> @@ -76,7 +76,7 @@ static int ljca_i2c_init(struct ljca_i2c_dev *ljca_i2c, u8 id)
> return ret < 0 ? ret : 0;
> }
>
> -static int ljca_i2c_start(struct ljca_i2c_dev *ljca_i2c, u8 slave_addr,
> +static int ljca_i2c_start(struct ljca_i2c_dev *ljca_i2c, u8 target_addr,
> enum ljca_xfer_type type)
> {
> struct ljca_i2c_rw_packet *w_packet =
> @@ -88,7 +88,7 @@ static int ljca_i2c_start(struct ljca_i2c_dev *ljca_i2c, u8 slave_addr,
>
> w_packet->id = ljca_i2c->i2c_info->id;
> w_packet->len = cpu_to_le16(sizeof(*w_packet->data));
> - w_packet->data[0] = (slave_addr << 1) | type;
> + w_packet->data[0] = (target_addr << 1) | type;
>
> ret = ljca_transfer(ljca_i2c->ljca, LJCA_I2C_START, (u8 *)w_packet,
> struct_size(w_packet, data, 1), (u8 *)r_packet,
> @@ -107,7 +107,7 @@ static int ljca_i2c_start(struct ljca_i2c_dev *ljca_i2c, u8 slave_addr,
> return 0;
> }
>
> -static void ljca_i2c_stop(struct ljca_i2c_dev *ljca_i2c, u8 slave_addr)
> +static void ljca_i2c_stop(struct ljca_i2c_dev *ljca_i2c, u8 target_addr)
Actually here the target address is not even used.
I will send a patch to remove it. As for this patch:
Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx>
Thanks,
Andi
