Hi Piotr,
On Fri, Jun 28, 2024 at 05:25:42PM GMT, Piotr Wojtaszczyk wrote:
> When del_timer_sync() is called in an interrupt context it throws a warning
> because of potential deadlock. The timer is used only to exit from
> wait_for_completion() after a timeout so replacing the call with
> wait_for_completion_timeout() allows to remove the problematic timer and
> its related functions altogether.
nice patch! I still would like an ack from Vladimir.
> Signed-off-by: Piotr Wojtaszczyk <piotr.wojtaszczyk@xxxxxxxxxxx>
Fixes: 41561f28e76a ("i2c: New Philips PNX bus driver")
Cc: Vitaly Wool <vitaly.wool@xxxxxxxxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx> # v2.6.20+
...
> @@ -653,7 +624,10 @@ static int i2c_pnx_probe(struct platform_device *pdev)
> alg_data->adapter.algo_data = alg_data;
> alg_data->adapter.nr = pdev->id;
>
> - alg_data->timeout = I2C_PNX_TIMEOUT_DEFAULT;
> + alg_data->timeout = msecs_to_jiffies(I2C_PNX_TIMEOUT_DEFAULT);
> + if (alg_data->timeout <= 1)
> + alg_data->timeout = 2;
I don't see the need for this check. The default timeout is
defined as 10.
Thanks,
Andi
