Re: [PATCH 3/6] arm64: dts: qcom: sc7280: Add IMX577 camera sensor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28/06/2024 19:32, Vikram Sharma wrote:
Add support for IMX577 camera sensor for SC7280 SoC.

Signed-off-by: Hariram Purushothaman <quic_hariramp@xxxxxxxxxxx>
Signed-off-by: Trishansh Bhardwaj <quic_tbhardwa@xxxxxxxxxxx>
Signed-off-by: Vikram Sharma <quic_vikramsa@xxxxxxxxxxx>
---
  arch/arm64/boot/dts/qcom/sc7280.dtsi | 33 +++++++++++++++++++++++++++++++++
  1 file changed, 33 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 9ac251fec262..1c99ee09a11a 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -5167,6 +5167,39 @@ cci3_sleep: cci3-sleep-state {
  				bias-pull-down;
  			};
+ cam2_default: cam2-default {
+				rst {
+					pins = "gpio78"; /*cam3*/

I don't think the /* cam3 */ adds much here TBH.

+					function = "gpio";
+					drive-strength = <2>;
+					bias-disable;
+				};
+
+				mclk {
+					pins = "gpio67"; /*cam3*/
+					function = "cam_mclk";
+					drive-strength = <2>; /*RB5 was 16 and i changed to 2 here*/

You can drop that comment too, actually more saliently, what are you changing from 16 to 2 since its being mentioned ?

---
bod




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux