Re: [PATCH v3 2/6] i2c: i801: Use a different adapter-name for IDF adapters

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Fri, Jun 21, 2024 at 2:25 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> On chipsets with a second 'Integrated Device Function' SMBus controller use
> a different adapter-name for the second IDF adapter.
>
> This allows platform glue code which is looking for the primary i801
> adapter to manually instantiate i2c_clients on to differentiate
> between the 2.
>
> This allows such code to find the primary i801 adapter by name, without
> needing to duplicate the PCI-ids to feature-flags mapping from i2c-i801.c.

...

> -       snprintf(priv->adapter.name, sizeof(priv->adapter.name),
> -               "SMBus I801 adapter at %04lx", priv->smba);
> +       if (priv->features & FEATURE_IDF)
> +               snprintf(priv->adapter.name, sizeof(priv->adapter.name),
> +                       "SMBus I801 IDF adapter at %04lx", priv->smba);
> +       else
> +               snprintf(priv->adapter.name, sizeof(priv->adapter.name),
> +                       "SMBus I801 adapter at %04lx", priv->smba);

Alternatively this can be

       snprintf(priv->adapter.name, sizeof(priv->adapter.name),
               "SMBus %s adapter at %04lx", priv->features &
FEATURE_IDF ? "I801 IDF" : "I801", priv->smba);

This will save a few bytes here and there.

-- 
With Best Regards,
Andy Shevchenko