Re: [PATCH v4 2/6] hwmon: Add support for SPD5118 compliant temperature sensors

[Guenter Roeck <linux@xxxxxxxxxxxx>]

On 6/4/24 01:48, Stephen Horvath wrote:
> Hi,
>
> On 4/6/24 14:02, Guenter Roeck wrote:
> > Add support for SPD5118 (Jedec JESD300) compliant temperature
> > sensors. Such sensors are typically found on DDR5 memory modules.
> >
> > Cc: René Rebe <rene@xxxxxxxxxxxx>
> > Cc: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> > Reviewed-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> > Tested-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > ---
> > v4: No change
> >
> > v3: Shorten JESD300-5B.01 to JESD300; 5B.01 refers to the version
> >      of the standard
> >      Drop unnecessary 'attr' parameter from spd5118_{read,write}_enable()
> >
> > v2: Drop PEC property documentation
> >      Add note indicating that alarm attributes are sticky until read
> >      to documentation
> >      Fix detect function
> >      Fix misspelling in Makefile (CONFIG_SENSORS_SPD5118->CONFIG_SENSORS_SPD5118)
> >
> >   Documentation/hwmon/index.rst   |   1 +
> >   Documentation/hwmon/spd5118.rst |  55 ++++
> >   drivers/hwmon/Kconfig           |  12 +
> >   drivers/hwmon/Makefile          |   1 +
> >   drivers/hwmon/spd5118.c         | 481 ++++++++++++++++++++++++++++++++
> >   5 files changed, 550 insertions(+)
> >   create mode 100644 Documentation/hwmon/spd5118.rst
> >   create mode 100644 drivers/hwmon/spd5118.c
>
> It seems to report correct temperatures for my sticks, so I guess:
>
> Tested-by: Stephen Horvath <s.horvath@xxxxxxxxxxxxxx>

Thanks!

Guenter