Re: [PATCH] i2c: designware: Fix the functionality flags of the slave-only interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 31 May 2024 12:23:26 +0300, Andy Shevchenko wrote:
> On Fri, May 31, 2024 at 11:17:48AM +0200, Jean Delvare wrote:
> > When an I2C adapter acts only as a slave, it should not claim to
> > support I2C master capabilities.
> > 
> > Fixes: 5b6d721b266a ("i2c: designware: enable SLAVE in platform module")
> > Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>  
> 
> The below can be separated by
> 
> ---
> 
> to avoid noise in the commit messages. The effect, namely Cc'ing to people,
> will stay the same.

Noted, I'll do that from now on.

> > Cc: Luis Oliveira <lolivei@xxxxxxxxxxxx>

BTW, the address above is no longer valid so it should be omitted when replying.

> > Cc: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
> > Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Cc: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> > Cc: Jan Dabros <jsd@xxxxxxxxxxxx>
> > Cc: Andi Shyti <andi.shyti@xxxxxxxxxx>
> > ---  
> 
> Other than that, LGTM,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Thanks,
-- 
Jean Delvare
SUSE L3 Support




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux