On 21/05/2024 09:12, Alvin Šipraga wrote: > On Sun, May 19, 2024 at 01:41:48PM GMT, Krzysztof Kozlowski wrote: >> On 17/05/2024 15:02, Alvin Šipraga wrote: >>> From: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx> >>> >>> The Beosound Shape has the same device tree bindings as an AD2425, so it >>> is sufficient to just add an entry to the compatible enum. >> >> ? If it has the same, then devices are compatible but your binding did >> not express it. > > OK, you're basically saying I should add it all in one patch? No, I said that your commit msg suggests they are compatible. I don't fully understand what you wanted to say by "same device tree bindings". But anyway, make it one patch. Best regards, Krzysztof