On Thu, 02 May 2024, Jarkko Nikula wrote: > On 4/30/24 12:36 PM, Andi Shyti wrote: > > Hi Andy, > > > > On Fri, Apr 26, 2024 at 05:30:24PM +0300, Andy Shevchenko wrote: > > > On Thu, Apr 25, 2024 at 02:44:37PM -0700, Florian Fainelli wrote: > > > > Rather than open code the i2c_designware string, utilize the newly > > > > defined constant in i2c-designware.h. > > > > > > Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > > > > > P.S> > > > Note, my tags for MFD patches does not imply that I agree on the general idea > > > of this series, it's just in case if it will be approved by the respective > > > maintainers (I²C / MFD / etc). > > > > I waited a bit to see if more comments were coming. > > > Well I had doubts about the idea will it help maintaining code or do the > opposite but didn't receive a reply from the patch author: > > https://lore.kernel.org/linux-i2c/62e58960-f568-459d-8690-0c9c608a4d9f@xxxxxxxxxxxxxxx/ > > Also Lee Jones have similar concerns: > > https://lore.kernel.org/linux-i2c/20240502071751.GA5338@xxxxxxxxxx/ Right. It's a NACK from me, sorry. -- Lee Jones [李琼斯]
