On 25/04/2024 23:36, Eddie James wrote: > Since there are multiple FSI controllers documented, the common > properties should be documented separately and then referenced > from the specific controller documentation. > > Signed-off-by: Eddie James <eajames@xxxxxxxxxxxxx> > --- > + > + no-scan-on-init: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + The FSI controller cannot scan the bus during initialization. > + > +patternProperties: > + "cfam@[0-9a-f],[0-9a-f]": > + type: object > + properties: > + chip-id: > + $ref: /schemas/types.yaml#/definitions/uint32 Missing description > + > + reg: > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 1 > + > + required: > + - reg > + > + additionalProperties: true> + > +additionalProperties: true > + > +examples: > + - | > + fsi@3400 { > + #address-cells = <2>; > + #size-cells = <0>; > + compatible = "fsi-controller"; No, there is no such compatible here. > + reg = <0x3400 0x400>; Neither reg. Also, keep order of properties matching DTS coding style. Best regards, Krzysztof